Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • L lustre-release
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • debian-packagesdebian-packages
  • lustre-release
  • Repository
Switch branch/tag
  • lustre-release
  • lustre
  • llite
  • llite_lib.c
Find file BlameHistoryPermalink
  • Andreas Dilger's avatar
    LU-13499 obd: fix printing of client connection UUID · 9abdf96e
    Andreas Dilger authored May 01, 2020
    The client connection UUID sent to the servers (ASCII format) was
    being truncated to only 16 bytes in size, like '595f3c6a-20ae-4'
    instead of a full UUID like '18ae0f9a-4b09-4599-8ced-0f2126eab425'.
    
    This was caused by using UUID_SIZE to limit the size of the "%pU"
    string printed to avoid overflowing the target buffer, but in fact
    UUID_SIZE is the size of the binary uuid_t (16 bytes) instead of
    the size of struct obd_uuid (40 bytes) where the ASCII version of
    the UUID is stored.
    
    Fix this to use sizeof(target) rather than an external constant,
    which is exactly why sizeof(target) should always be used.  The
    usage in osd_scrub.c is not actually broken, but it is still
    better to use sizeof(target) to avoid future inconsistencies.
    
    Fixes: 604c266a
    
     ("LU-11803 obd: replace class_uuid with linux kernel version")
    Signed-off-by: default avatarAndreas Dilger <adilger@whamcloud.com>
    Change-Id: I05325646cd632a09997d6632a483909629ce7057
    Reviewed-on: https://review.whamcloud.com/38443
    
    
    Tested-by: default avatarjenkins <devops@whamcloud.com>
    Reviewed-by: default avatarJames Simmons <jsimmons@infradead.org>
    Tested-by: default avatarMaloo <maloo@whamcloud.com>
    Reviewed-by: default avatarArshad Hussain <arshad.super@gmail.com>
    Reviewed-by: default avatarMike Pershin <mpershin@whamcloud.com>
    Reviewed-by: default avatarOleg Drokin <green@whamcloud.com>
    9abdf96e

https://git.gsi.de is provided by CIT→Linux&Web | GSI Helmholtzzentrum fuer Schwerionenforschung GmbH | Imprint (in German) | Privacy policy