diff --git a/lustre/ChangeLog b/lustre/ChangeLog index 020b17d55ef1f915394fa7b67ad1536383ee3cfc..25ba50e7db0056b0ce0dfd90f517a08ba94d8b70 100644 --- a/lustre/ChangeLog +++ b/lustre/ChangeLog @@ -25,11 +25,17 @@ tbd Sun Microsystems, Inc. 'tunefs.lustre --param="mdt.quota_type=ug1" $MDTDEV'. For more information, please refer to bugzilla 13904. +Severity : normal +Bugzilla : 12888 +Description: mds_mfd_close() ASSERTION(rc == 0) +Details : In mds_mfd_close(), we need protect inode's writecount change + within its orphan write semaphore to prevent possible races. + Severity : minor Bugzilla : 14645 Frequency : rare, on shutdown ost Description: don't hit live lock with umount ost. -Description: shrink_dcache_parent can be in long loop with destroy dentries, +Details : shrink_dcache_parent can be in long loop with destroy dentries, use shrink_dcache_sb instead. Severity : minor diff --git a/lustre/mds/mds_open.c b/lustre/mds/mds_open.c index d5b8cce3d10c74ace35c32bff2daea2cf1cc8b20..3750a0cd752ab968869091049972a270eaa3ee1c 100644 --- a/lustre/mds/mds_open.c +++ b/lustre/mds/mds_open.c @@ -1280,8 +1280,7 @@ int mds_mfd_close(struct ptlrpc_request *req, int offset, inode->i_nlink, mds_orphan_open_count(inode)); last_orphan = mds_orphan_open_dec_test(inode) && - mds_inode_is_orphan(inode); - MDS_UP_WRITE_ORPHAN_SEM(inode); + mds_inode_is_orphan(inode); /* this is half of the actual "close" */ if (mfd->mfd_mode & FMODE_WRITE) { @@ -1290,6 +1289,9 @@ int mds_mfd_close(struct ptlrpc_request *req, int offset, } else if (mfd->mfd_mode & MDS_FMODE_EXEC) { mds_allow_write_access(inode); } + /* here writecount change also needs protection from orphan write sem. + * so drop orphan write sem after mds_put_write_access, bz 12888. */ + MDS_UP_WRITE_ORPHAN_SEM(inode); if (last_orphan && unlink_orphan) { int stripe_count = 0;