From 128fd4f71d78b23ee49ecc890ca58a57dd44919a Mon Sep 17 00:00:00 2001
From: bobijam <bobijam>
Date: Tue, 13 May 2008 01:28:34 +0000
Subject: [PATCH] Branch b1_6 b=12888 i=johann, green
Description: mds_mfd_close() ASSERTION(rc == 0)
Details : In mds_mfd_close(), we need protect inode's writecount change
within its orphan write semaphore to prevent possible races.
---
lustre/ChangeLog | 8 +++++++-
lustre/mds/mds_open.c | 6 ++++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/lustre/ChangeLog b/lustre/ChangeLog
index 020b17d55e..25ba50e7db 100644
--- a/lustre/ChangeLog
+++ b/lustre/ChangeLog
@@ -25,11 +25,17 @@ tbd Sun Microsystems, Inc.
'tunefs.lustre --param="mdt.quota_type=ug1" $MDTDEV'.
For more information, please refer to bugzilla 13904.
+Severity : normal
+Bugzilla : 12888
+Description: mds_mfd_close() ASSERTION(rc == 0)
+Details : In mds_mfd_close(), we need protect inode's writecount change
+ within its orphan write semaphore to prevent possible races.
+
Severity : minor
Bugzilla : 14645
Frequency : rare, on shutdown ost
Description: don't hit live lock with umount ost.
-Description: shrink_dcache_parent can be in long loop with destroy dentries,
+Details : shrink_dcache_parent can be in long loop with destroy dentries,
use shrink_dcache_sb instead.
Severity : minor
diff --git a/lustre/mds/mds_open.c b/lustre/mds/mds_open.c
index d5b8cce3d1..3750a0cd75 100644
--- a/lustre/mds/mds_open.c
+++ b/lustre/mds/mds_open.c
@@ -1280,8 +1280,7 @@ int mds_mfd_close(struct ptlrpc_request *req, int offset,
inode->i_nlink, mds_orphan_open_count(inode));
last_orphan = mds_orphan_open_dec_test(inode) &&
- mds_inode_is_orphan(inode);
- MDS_UP_WRITE_ORPHAN_SEM(inode);
+ mds_inode_is_orphan(inode);
/* this is half of the actual "close" */
if (mfd->mfd_mode & FMODE_WRITE) {
@@ -1290,6 +1289,9 @@ int mds_mfd_close(struct ptlrpc_request *req, int offset,
} else if (mfd->mfd_mode & MDS_FMODE_EXEC) {
mds_allow_write_access(inode);
}
+ /* here writecount change also needs protection from orphan write sem.
+ * so drop orphan write sem after mds_put_write_access, bz 12888. */
+ MDS_UP_WRITE_ORPHAN_SEM(inode);
if (last_orphan && unlink_orphan) {
int stripe_count = 0;
--
GitLab