diff --git a/lustre/ChangeLog b/lustre/ChangeLog index 424e4b772641ffc872cc0ab518911cce10e511ae..71deebe997bcfae847ff782f8f0c1e9c16371baa 100644 --- a/lustre/ChangeLog +++ b/lustre/ChangeLog @@ -389,6 +389,14 @@ Details : When processing waiting list for read extent lock and meeting read status of conflictness, since we are guaranteed there are no conflicting locks in the rest of the list. +Severity : normal +Bugzilla : 14774 +Description: Time out and refuse to reconnect +Details : When the failover node is the primary node, it is possible + to have two identical connections in imp_conn_list. We must + compare not conn's pointers but NIDs, otherwise we + can defeat connection throttling. + -------------------------------------------------------------------------------- 2007-12-07 Cluster File Systems, Inc. <info@clusterfs.com> diff --git a/lustre/ptlrpc/import.c b/lustre/ptlrpc/import.c index efae267becefd0915d790928254ae834233cc31c..ca48d55db5aa89b136b5f12a02eb91cd7376524a 100644 --- a/lustre/ptlrpc/import.c +++ b/lustre/ptlrpc/import.c @@ -566,7 +566,12 @@ static void ptlrpc_maybe_ping_import_soon(struct obd_import *imp) struct obd_import_conn, oic_item); - if (imp->imp_conn_current != imp_conn) { + /* XXX: When the failover node is the primary node, it is possible + * to have two identical connections in imp_conn_list. We must + * compare not conn's pointers but NIDs, otherwise we can defeat + * connection throttling. (See bug 14774.) */ + if (imp->imp_conn_current->oic_conn->c_self != + imp_conn->oic_conn->c_self) { ptlrpc_ping_import_soon(imp); wake_pinger = 1; }