diff --git a/lnet/klnds/ptllnd/ptllnd_modparams.c b/lnet/klnds/ptllnd/ptllnd_modparams.c index 044353ab979f407c0595737ae8c86daebd582be0..1d538e9bc613468bb99e7f77e436859cb9fd850c 100644 --- a/lnet/klnds/ptllnd/ptllnd_modparams.c +++ b/lnet/klnds/ptllnd/ptllnd_modparams.c @@ -80,7 +80,7 @@ CFS_MODULE_PARM(ack_puts, "i", int, 0644, "get portals to ack all PUTs"); #ifdef CRAY_XT3 -static int ptltrace_on_timeout = 1; +static int ptltrace_on_timeout = 0; CFS_MODULE_PARM(ptltrace_on_timeout, "i", int, 0644, "dump ptltrace on timeout"); diff --git a/lnet/klnds/ptllnd/ptllnd_ptltrace.c b/lnet/klnds/ptllnd/ptllnd_ptltrace.c index 30064dcbb83997e9cafb8c1c98d2b58a4bc4fcd9..91ba7afefa7f452835b5f0677c745839f6796ec0 100644 --- a/lnet/klnds/ptllnd/ptllnd_ptltrace.c +++ b/lnet/klnds/ptllnd/ptllnd_ptltrace.c @@ -48,7 +48,8 @@ kptllnd_ptltrace_to_file(char *filename) filp = cfs_filp_open(filename, O_CREAT|O_EXCL|O_WRONLY|O_LARGEFILE, 0600, &rc); if (filp == NULL) { - CERROR("Error %d creating %s\n", rc, filename); + if (rc != -EEXIST) + CERROR("Error %d creating %s\n", rc, filename); goto out; } @@ -80,7 +81,11 @@ kptllnd_ptltrace_to_file(char *filename) break; } - LASSERT (start >= tmpbuf && start + len <= tmpbuf + PAGE_SIZE); + if (start < tmpbuf || start + len > tmpbuf + PAGE_SIZE) { + CERROR("ptl_proc_read bug: %p for %d not in %p for %d\n", + start, len, tmpbuf, PAGE_SIZE); + break; + } rc = cfs_filp_write(filp, start, len, cfs_filp_poff(filp)); if (rc != len) { diff --git a/lnet/klnds/ptllnd/ptllnd_rx_buf.c b/lnet/klnds/ptllnd/ptllnd_rx_buf.c index ce21e9559b80626b5e5d74107a361df8971fa786..847e265e2852c5ba936b255e09ad10cb04954ae7 100644 --- a/lnet/klnds/ptllnd/ptllnd_rx_buf.c +++ b/lnet/klnds/ptllnd/ptllnd_rx_buf.c @@ -415,10 +415,10 @@ kptllnd_rx_buffer_callback (ptl_event_t *ev) * odd-length message will misalign subsequent messages and * force the fixup below... */ if ((ev->mlength & 7) != 0) - CWARN("Message from %s has odd length %llu: " + CWARN("Message from %s has odd length "LPU64": " "probable version incompatibility\n", kptllnd_ptlid2str(ev->initiator), - ev->mlength); + (__u64)ev->mlength); #endif rx = kptllnd_rx_alloc(); if (rx == NULL) {