LV issueshttps://git.gsi.de/groups/phelix/lv/-/issues2024-03-15T08:22:14Zhttps://git.gsi.de/phelix/lv/wombat/-/issues/225AO Control: Wrong Reference not recognized when loading AO control chain2024-03-15T08:22:14Zj.hornungAO Control: Wrong Reference not recognized when loading AO control chainThe AO control will not show an error when loading a AO control chain taken with a wrong SHS analysis reference. It only shows the error when trying to perform the "closed loop" operation.The AO control will not show an error when loading a AO control chain taken with a wrong SHS analysis reference. It only shows the error when trying to perform the "closed loop" operation.Udo Eisenbarthu.eisenbarth@gsi.deUdo Eisenbarthu.eisenbarth@gsi.dehttps://git.gsi.de/phelix/lv/wombat/-/issues/223FROG Calibrator: Additionally save raw camera data user input in order to per...2024-02-20T06:55:23Zj.hornungFROG Calibrator: Additionally save raw camera data user input in order to perform a post-analysis of the calibrationInstead of saving the spectral and temporal calibration results only, it would be very good to also save additional values / acquisitions in order to perform a post-analysis of the calibration:
Spectral calibration:
- Wavelengths used f...Instead of saving the spectral and temporal calibration results only, it would be very good to also save additional values / acquisitions in order to perform a post-analysis of the calibration:
Spectral calibration:
- Wavelengths used for the calibration
- Respective pixel cooresponding to the different wavelengths (raw value)
- Acquired image used for the calibation
Temporal calibration:
- Delay stage values (µm)
- Respective pixel corresponding to the maximum of the FROG trace in time-axis direction (raw value)
- Image for each acquired time-/ delay-stepj.hornungj.hornunghttps://git.gsi.de/phelix/lv/wombat/-/issues/221AO Control: Automatic movement of DM after loading ControlChain2024-02-19T17:00:42Zb.zielbauerAO Control: Automatic movement of DM after loading ControlChainWhen loading ControlChain, the mirror directly moves to neutral (?) position which might mess up a previous result. Implement button or message to deactivate moving to neutral when loading a ControlChain?When loading ControlChain, the mirror directly moves to neutral (?) position which might mess up a previous result. Implement button or message to deactivate moving to neutral when loading a ControlChain?https://git.gsi.de/phelix/lv/wombat/-/issues/217Wrong maximum time and Pulse duration visualization in Osci Analysis2023-06-29T10:50:18Zj.hornungWrong maximum time and Pulse duration visualization in Osci AnalysisThe "time" of the maximum and pulse duration is not correctly visualized within the Oscilloscope Analysis. It appears before the pulseThe "time" of the maximum and pulse duration is not correctly visualized within the Oscilloscope Analysis. It appears before the pulsej.hornungj.hornunghttps://git.gsi.de/phelix/lv/imagesource/-/issues/29Remove FireWire und Basler Subklassen aufräumen2023-12-12T13:58:16ZChristian BrabetzRemove FireWire und Basler Subklassen aufräumenRemove FireWire und Basler Subklassen aufräumen. Das dann nur noch eine sein wird.
Irgendwelche einwände dagegen? Ich sehe nicht das wir noch FireWire unterstüzen müssen ;)
@u.eisenbarth @j.b.ohlandRemove FireWire und Basler Subklassen aufräumen. Das dann nur noch eine sein wird.
Irgendwelche einwände dagegen? Ich sehe nicht das wir noch FireWire unterstüzen müssen ;)
@u.eisenbarth @j.b.ohlandUdo Eisenbarthu.eisenbarth@gsi.deUdo Eisenbarthu.eisenbarth@gsi.de2024-06-06https://git.gsi.de/phelix/lv/wombat/-/issues/204Nearfield Analysis: Fixed angles2022-01-25T07:45:05ZUdo Eisenbarthu.eisenbarth@gsi.deNearfield Analysis: Fixed anglesAdd option to set fixed ellipse angles. This would prevent an major/minor axis flip while measuring a Gaussian mode / M^2Add option to set fixed ellipse angles. This would prevent an major/minor axis flip while measuring a Gaussian mode / M^2https://git.gsi.de/phelix/lv/wombat/-/issues/203Gauss Mode Measurement: Export to CSV2022-01-25T07:42:27ZUdo Eisenbarthu.eisenbarth@gsi.deGauss Mode Measurement: Export to CSVExport / Import measured values (positions / beam diamters) to a CSV file.Export / Import measured values (positions / beam diamters) to a CSV file.https://git.gsi.de/phelix/lv/wombat/-/issues/201Implement more robust DM response recording scheme with Hadamard modes2021-12-10T13:58:45Zj.b.ohlandImplement more robust DM response recording scheme with Hadamard modesWe've been doing it wrong all the time ... again. Recording a response using individual actuator pokes is "the worst possible way" to do it as the signal to noise ratio is very bad and the temporal evolution of the wavefront during recor...We've been doing it wrong all the time ... again. Recording a response using individual actuator pokes is "the worst possible way" to do it as the signal to noise ratio is very bad and the temporal evolution of the wavefront during recording is not cancelled out very efficient. Turns out that acting on all the DM channels all the time in an orthogonal fashion is very beneficial and will lead to a much cleaner response, which increases stability and convergence speed of the loop. Using Hadamard modes as channel offsets seems to be an excellent approach.
Here's a paper - you can skip to section 5.
https://www.researchgate.net/publication/241763342_Calibration_of_a_curvature_sensor_bimorph_mirror_AO_system_Interactiocn_matrix_measurement_on_MACAO_systemshttps://git.gsi.de/phelix/lv/wombat/-/issues/195Save 12 Bit image results in 16 bit when opening with Matlab / ImageJ2021-12-07T14:25:36Zj.hornungSave 12 Bit image results in 16 bit when opening with Matlab / ImageJWhen saving a 12 Bit image (AcA1920-40mg) and re-loading it with Matlab or ImageJ it is declared as a 16 bit unsigned integer scaled to 65536 (in case of a saturated image).When saving a 12 Bit image (AcA1920-40mg) and re-loading it with Matlab or ImageJ it is declared as a 16 bit unsigned integer scaled to 65536 (in case of a saturated image).https://git.gsi.de/phelix/lv/wombat/-/issues/194Camera: Add wavelength as config param2021-11-25T12:11:43ZUdo Eisenbarthu.eisenbarth@gsi.deCamera: Add wavelength as config paramAlthough this parameter is not needed by the cam actor itself it could be handed over to various other modules such as shs calibrator, focus reconstructor, gauss mode / M^2 measurement etc...Although this parameter is not needed by the cam actor itself it could be handed over to various other modules such as shs calibrator, focus reconstructor, gauss mode / M^2 measurement etc...https://git.gsi.de/phelix/lv/imagesource/-/issues/26ImgSrcSimulationCalculated: Add optional bit depth quantization2021-11-24T13:41:21ZUdo Eisenbarthu.eisenbarth@gsi.deImgSrcSimulationCalculated: Add optional bit depth quantizationCurrently the bit depth only determines the maximum value (for rel. amplitude = 1.0). A quantization could further make things more realistically. Where to implement this? In principle noise should also be quantized....Currently the bit depth only determines the maximum value (for rel. amplitude = 1.0). A quantization could further make things more realistically. Where to implement this? In principle noise should also be quantized....https://git.gsi.de/phelix/lv/imagesource/-/issues/25ImgSrcSimulation: Add possibility to "saturate" images.2021-11-24T13:36:15ZUdo Eisenbarthu.eisenbarth@gsi.deImgSrcSimulation: Add possibility to "saturate" images.If a relative amplitude > 1.0 is used an additional switch could decide wether the values should be coerced.If a relative amplitude > 1.0 is used an additional switch could decide wether the values should be coerced.https://git.gsi.de/phelix/lv/wombat/-/issues/187JustX: Show numeric value in intensity bar2021-10-12T10:44:54ZUdo Eisenbarthu.eisenbarth@gsi.deJustX: Show numeric value in intensity barhttps://git.gsi.de/phelix/lv/wombat/-/issues/180Multiwave Shearing Interferometer Simulation?2021-09-23T07:46:25Zj.b.ohlandMultiwave Shearing Interferometer Simulation?As we got a shearing interferometer simulator that overlaps two displayed copies of a field, tiltet with respect to each other, generalizing the algorithm to multi wave lateral shearing interferometry (MWLSI) wouldn't be a big deal! The ...As we got a shearing interferometer simulator that overlaps two displayed copies of a field, tiltet with respect to each other, generalizing the algorithm to multi wave lateral shearing interferometry (MWLSI) wouldn't be a big deal! The principle stays the same, just so more than two copies are overlaped and the tilt/displacement follows a radial symmetry with N copies. This natually includes the interferogram produced by the SID4 (PHASIX) sensor. Having this implemented would be a first step towards implementing the evaluation of corresponding data.
The only thing that does not generalize that I see is that the tilt and displacement for MWLSI are described by the initial relative tilt of the dublicates and the distance of the observation plane to the plane where the dublicates are generated, while for the regular shearplate the thickness and wedge of the glass are used. Those are of course only a matter of how the user enters the properties of the simulated interferogram. I guess having a parent "Shearing Interferometer Simulater" and to children "Shearplate Simulator" and "Multiwave Lateral Shearing Interferometry Simulator" (or a more catchy name) that take different inputs would be a valid approach ...
Original Three Wave LSI: https://www.researchgate.net/publication/46381969_Three-wave_lateral_shearing_interferometer
MWLSI: https://doi.org/10.1117/12.681533https://git.gsi.de/phelix/lv/wombat/-/issues/178Design backwards-compatible data saving system2021-08-31T08:54:26Zj.b.ohlandDesign backwards-compatible data saving systemI think it may be well spent time to think about how one could save LV-Objects in a manner that still allows to load it after the class was updated.
Example: During I020, I saved some SABER-files that I wish to use for data evaluation no...I think it may be well spent time to think about how one could save LV-Objects in a manner that still allows to load it after the class was updated.
Example: During I020, I saved some SABER-files that I wish to use for data evaluation now. Since the "valid"-field was removed from the class, I cannot load them in the latest versions of WOMBAT and need to check out older versions.
The solution may not be trivial, but a combination of object serialization (maybe XML?) and object specific version IDs that are stored in the class itself could work. Here, one could implement a deserialization method that first retrieves the version ID and then converts the rest of the data accordingly into the most recent version.https://git.gsi.de/phelix/lv/wombat/-/issues/168Add basic documentation2021-08-23T14:04:46ZUdo Eisenbarthu.eisenbarth@gsi.deAdd basic documentationAt least README.md with some hints for configuration an build info.At least README.md with some hints for configuration an build info.https://git.gsi.de/phelix/lv/wombat/-/issues/166Cleanup of Dataloop Do's2021-08-23T11:40:44ZUdo Eisenbarthu.eisenbarth@gsi.deCleanup of Dataloop Do'shttps://git.gsi.de/phelix/lv/shs_common/-/issues/8possible duplicate GetValidArray and ReadValidArray2021-12-15T08:18:29ZChristian Brabetzpossible duplicate GetValidArray and ReadValidArraySHS Common -> GradientField class: possible duplicate
GetValidArray
ReadValidArraySHS Common -> GradientField class: possible duplicate
GetValidArray
ReadValidArrayv1.5 M1Udo Eisenbarthu.eisenbarth@gsi.deUdo Eisenbarthu.eisenbarth@gsi.dehttps://git.gsi.de/phelix/lv/wombat/-/issues/145SHS Analysis: Remove outliers in Shifts2021-08-26T11:06:35Zj.b.ohlandSHS Analysis: Remove outliers in ShiftsXRays may cause hotpixels on shot, which may be falsely detected as a spot by the analysis and result in crazy large gradients in single points - which or course mess up the reconstructed wavefront.
One could investigate an algorithm to...XRays may cause hotpixels on shot, which may be falsely detected as a spot by the analysis and result in crazy large gradients in single points - which or course mess up the reconstructed wavefront.
One could investigate an algorithm to detect these outliers, e.g. by subtracting the tilt and comparing the amplitude of the shifts. If one or two shifts exceed 2 or 3 sigma from the main distribution, they could be considered outliers and can be removed from the Gradient.
Excample images with XRays like these were recorded at PTAS during I020 - one can look up the shotnumbers in the shotbooks. According comments have been made in the "WF"-row.https://git.gsi.de/phelix/lv/imagesource/-/issues/23Imaqdx: Add general 'Set IMAQ attribute'2021-06-11T10:34:03ZUdo Eisenbarthu.eisenbarth@gsi.deImaqdx: Add general 'Set IMAQ attribute'