Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
L
libheimdal-kadm5-perl
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
External wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
debian-packages
libheimdal-kadm5-perl
Commits
1f4d368d
Commit
1f4d368d
authored
7 years ago
by
Russ Allbery
Browse files
Options
Downloads
Patches
Plain Diff
Add more comments to the library call patch
parent
ff22db28
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
debian/patches/fix-library-calls.patch
+20
-1
20 additions, 1 deletion
debian/patches/fix-library-calls.patch
with
20 additions
and
1 deletion
debian/patches/fix-library-calls.patch
+
20
−
1
View file @
1f4d368d
Description: Call the public API functions
, not
internal
_c functi
ons
Description: Call the public
kadm5
API functions
instead of the
internal on
e
s
Author: Russ Allbery <rra@debian.org>
Author: Russ Allbery <rra@debian.org>
The kadm5_c_* functions are an internal API. The public functions
are the ones without the _c, which dispatch to the internal functions
depending on whether one links with the client library or the server
library. By calling the _c functions, we don't get the benefit of
prototype checking and fail if the internal function signature ever
changes.
The latter has now happened with Heimdal 1.6 currently used in Debian,
and as a result the create_principal and chpass_principal functions
here have stopped working because they provide the wrong number of
arguments and the Heimdal library sees random stack garbage as the
additional function arguments.
Replace all C calls to use the versions without _c, since this module
doesn't attempt to support the _s and _c interfaces simultaneously
anyway and therefore no benefit accrues from calling the _c functions.
This also fixes the backward-compatibility problem, since the public
API did not change, only the internal function API.
diff --git a/Kadm5.xs b/Kadm5.xs
diff --git a/Kadm5.xs b/Kadm5.xs
index f1312f8..8ee5d73 100644
index f1312f8..8ee5d73 100644
--- a/Kadm5.xs
--- a/Kadm5.xs
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment