LU-553 build: improve checks for commit-msg
Improve the checks done by the commit-msg script. It now ensures that all the parts of the commit message are present. - validate that the Change-Id: generated from 'git hash-object' is not empty, since this can happen if git is unhappy with the options - check for only one Change-Id: line (multiple Signed-off-by: OK) - describe the "component:" field better, with some examples If there was an error committing the message, save a copy to a temporary file, so that it can be edited and re-used, instead of having to recreate it each time, or fetch it from .git/COMMIT_MSG. Add a simple regression test with good & bad commit messages, so it is easier to verify that any changes made to the script will continue to both detect errors, and pass valid commit messages. Signed-off-by:Andreas Dilger <adilger@whamcloud.com> Change-Id: I15cb3690560400a591598997424cf79dee3a039d Reviewed-on: http://review.whamcloud.com/1688 Tested-by: Hudson Tested-by:
Maloo <whamcloud.maloo@gmail.com> Reviewed-by:
Johann Lombardi <johann@whamcloud.com> Reviewed-by:
Mikhail Pershin <tappro@whamcloud.com>
Showing
- build/commit-msg 136 additions, 56 deletionsbuild/commit-msg
- build/commit.badcid 16 additions, 0 deletionsbuild/commit.badcid
- build/commit.bademail 14 additions, 0 deletionsbuild/commit.bademail
- build/commit.badname 14 additions, 0 deletionsbuild/commit.badname
- build/commit.badsign 14 additions, 0 deletionsbuild/commit.badsign
- build/commit.dupcid 16 additions, 0 deletionsbuild/commit.dupcid
- build/commit.nobody 3 additions, 0 deletionsbuild/commit.nobody
- build/commit.nocmp 14 additions, 0 deletionsbuild/commit.nocmp
- build/commit.nojira 14 additions, 0 deletionsbuild/commit.nojira
- build/commit.nosign 12 additions, 0 deletionsbuild/commit.nosign
- build/commit.nosum 12 additions, 0 deletionsbuild/commit.nosum
- build/commit.ok_cid 15 additions, 0 deletionsbuild/commit.ok_cid
- build/commit.ok_dupsign 15 additions, 0 deletionsbuild/commit.ok_dupsign
- build/commit.ok_nocid 14 additions, 0 deletionsbuild/commit.ok_nocid
- build/test-commit-msg.sh 17 additions, 0 deletionsbuild/test-commit-msg.sh
Loading
Please register or sign in to comment