[SIL-317] Refactor getInputAddress and getOutputAddress and change

address variables from unsigned to signed

silecs-communication-cpp/src/silecs-communication/interface/equipment/SilecsDevice.h

@@ -127,50 +127,18 @@ namespace Silecs
 		Device(PLC* thePLC, const ElementXML& deviceNode, boost::ptr_vector<ElementXML>& blockNodes);
 		virtual ~Device();
 
-	    inline unsigned long& getInputAddress(AccessArea area)
+	    inline long& getInputAddress(AccessArea area)
 	    {
-	        switch (area)
-	        {
-	            case Digital:
-	            {
-	                return di_address_;
-	                break;
-	            }
-	            case Analog:
-	            {
-	                return ai_address_;
-	                break;
-	            }
-	            case Memory:
-	            {
-	                return address_;
-	                break;
-	            }
-	        }
-	        return address_;
+	      if (area == Digital) return di_address_;
+	      else if (area == Analog) return ai_address_;
+	      return address_;
 	    }
 
-	    inline unsigned long& getOutputAddress(AccessArea area)
+	    inline long& getOutputAddress(AccessArea area)
 	    {
-	        switch (area)
-	        {
-	            case Digital:
-	            {
-	                return do_address_;
-	                break;
-	            }
-	            case Analog:
-	            {
-	                return ao_address_;
-	                break;
-	            }
-	            case Memory:
-	            {
-	                return address_;
-	                break;
-	            }
-	        }
-	        return address_;
+	      if (area == Digital) return do_address_;
+	      else if (area == Analog) return ao_address_;
+	      return address_;
 	    }
 
 		Register* instantiateRegister(const boost::shared_ptr<ElementXML>& registerNode);
@@ -207,11 +175,11 @@ namespace Silecs
 
 	    /// Device attributes
 	    std::string label_;
-	    unsigned long address_;
-	    unsigned long ai_address_;
-	    unsigned long ao_address_;
-	    unsigned long di_address_;
-	    unsigned long do_address_;
+	    long address_;
+	    long ai_address_;
+	    long ao_address_;
+	    long di_address_;
+	    long do_address_;
 
 		/// Register collection of that device
 		registerVectorType registerCol_;