Fix: Apply all migrations
Issue #76 (closed)
Merge request reports
Activity
added bug silecs-cli labels
requested review from @al.schwinn
assigned to @m.nabywaniec
- Resolved by al.schwinn
Looks that now works well, previously I looked in installation directory, now I look for migration modules in
silecs-codegen
.I see 2 problems:
-
Every time migration is run, backup is created. I think that it is logical that only the first time backup should be made. Am I right @al.schwinn? EDIT: Now I fixed that soby adding parameter if create backup. Normally we will create backup only during first migration Seems to work as well:
-
The new file is not structurized properly, e.g. whole controller is in one line.
Edited by m.nabywaniec -
added 1 commit
- bbbf6174 - Create backup of silecs document only during first migration
Looks that now works well, previously I looked in installation directory, now I look for migration modules in
silecs-codegen
.Thank you @m.nabywaniec , now all in-between migrations seem to be executed \o/
I had some old "Volatile-Register" in the Setting-Block after migration with the 0.10.0 example, so probably one of the migration steps has some bug ... however not a matter of this MR, and probably these ancient versions are anyhow not relevant.
- Resolved by al.schwinn
- Resolved by al.schwinn
The new file is not structurized properly, e.g. whole controller is in one line.
True .. iirc, it was always like that. If you know a simple way to apply some kind of formatting, feel free to add it ! (could as well be done in a separate issue/MR .. as you prefer ! )
mentioned in commit 8851ba13