Remove meta pointers

This should cover what you described in !7 (comment 52164).

Addresses #50 (closed)

Existing tests are passing. I only had to update the one that used meta pointers directly.

For FULL_SEQ the State is used in full and I believe properly handled. However for Streaming and Triggered the state is not used in any meaningful way. Should it be?

One more thing I noticed is that as far as I can see streaming is calling updateMetaWindowAccordingToSampleWindow twice, once in the actual updateStreamingWindowIter and then again in the DataReadyHandlerStreaming::moveWindows. If I remove either one of the calls the tests still pass, while removing both makes the tests fail, so maybe one of them is redundant.

changed milestone to %7.0.0

requested review from @al.schwinn

added 1 commit

• c030b6ee - Add missing throw statements

Compare with previous version

changed the description

For FULL_SEQ the State is used in full and I believe properly handled. However for Streaming and Triggered the state is not used in any meaningful way. Should it be?

No, I think it is fine as you did .. let's just rename the initialze method to make clear that it is optional.

One more thing I noticed is that as far as I can see streaming is calling updateMetaWindowAccordingToSampleWindow twice, once in the actual updateStreamingWindowIter and then again in the DataReadyHandlerStreaming::moveWindows. If I remove either one of the calls the tests still pass, while removing both makes the tests fail, so maybe one of them is redundant.

Yea, even with git blame I cannot tell why I added that additional updateStreamingWindowIter call inside DataReadyHandlerStreaming::moveWindows. I'll just remove that extra-call for now. (I suppose sooner or later I/we have as well to iterator on the parallel update feature ... though for now let's ignore it)

Thank you, mostly looks good to me !

added 1 commit

• 3cdd7780 - Rename to avoid confusion

Compare with previous version

Meh, due to !8 (merged) this MR now needs a manual rebase

added 8 commits

• 3cdd7780...79021e9d - 3 commits from branch master
• 707ebe87 - Get rid of meta_end_
• 89653649 - Remove meta_start_
• 444b781d - Add missing throw statements
• 0f9efb04 - Rename to avoid confusion
• 643ef8bb - Add brackets

Compare with previous version

merged

mentioned in commit e14012bc

resolved all threads

mentioned in commit 901fc4df

mentioned in merge request !10 (merged)

mentioned in commit 1fff70f8