- Jan 19, 2012
-
-
Andreas Dilger authored
Allow blank lines after the signoff section, since there will usually be a blank line between the signoff and the checkpatch.pl output. Improve the EMAILPAT regex to detect bad email addresses that do not have a full name (at least 2 parts) and a full domain (also with at least 2 parts). Allow a generic "{Organization}-bug-id:" line in the signoff section to allow linking the patch commit into arbitrary bug databases for ease of tracking patches. Add test cases for all of these changes. Signed-off-by:
Andreas Dilger <adilger@whamcloud.com> Change-Id: Iaf14f6c985d3dd4837064d29071bd9acd8031d67 Reviewed-on: http://review.whamcloud.com/1867 Reviewed-by:
<bruce.korb@gmail.com> Tested-by: Hudson Tested-by:
Maloo <whamcloud.maloo@gmail.com> Reviewed-by:
Bobi Jam <bobijam@whamcloud.com> Reviewed-by:
Oleg Drokin <green@whamcloud.com>
-
- Nov 24, 2011
-
-
Andreas Dilger authored
Improve the checks done by the commit-msg script. It now ensures that all the parts of the commit message are present. - validate that the Change-Id: generated from 'git hash-object' is not empty, since this can happen if git is unhappy with the options - check for only one Change-Id: line (multiple Signed-off-by: OK) - describe the "component:" field better, with some examples If there was an error committing the message, save a copy to a temporary file, so that it can be edited and re-used, instead of having to recreate it each time, or fetch it from .git/COMMIT_MSG. Add a simple regression test with good & bad commit messages, so it is easier to verify that any changes made to the script will continue to both detect errors, and pass valid commit messages. Signed-off-by:
Andreas Dilger <adilger@whamcloud.com> Change-Id: I15cb3690560400a591598997424cf79dee3a039d Reviewed-on: http://review.whamcloud.com/1688 Tested-by: Hudson Tested-by:
Maloo <whamcloud.maloo@gmail.com> Reviewed-by:
Johann Lombardi <johann@whamcloud.com> Reviewed-by:
Mikhail Pershin <tappro@whamcloud.com>
-